fix(rxjs): Include index functions and improve scraper coverage (#2529) #2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
timeInterval appears twice now as http://localhost:9292/rxjs/api/operators/timeinterval and http://localhost:9292/rxjs/api/index/function/timeinterval. Is this intended? |
Thanks for catching that! Yeah, the duplication is actually intentional — it matches how the official RxJS docs list timeInterval in both the standalone functions and the operators section. Since it’s validly part of both, the scraper now reflects that to stay consistent with the source. That said, if you think we should clean it up or consolidate one of the paths in DevDocs, I’m happy to make the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2529
This PR enhances the RxJS documentation by introducing a dedicated Top-level Functions category in the DevDocs sidebar. This improves discoverability for core RxJS functions such as of(), from(), and merge(), which were previously uncategorized or grouped under "Miscellaneous".
✅ Changes Made:
Updated
lib::docs::filters::rxjs::entriesget_typeto returnTop-level Functionsfor root-levelapi/entries that don't belong to any operator class (e.g.,ajax,animationFrameScheduler, etc.).Sidebar now reflects the new grouping for standalone functional APIs.
Ensured no impact to existing guide sections or categorized operators.
🧪 Testing
Ran the scraper locally and verified a successful build
Confirmed sidebar now contains a Top-level Functions section
Verified visual consistency and link correctness across updated entries